add RunWithContext + remove signal cancellation #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #975 +/- ##
==========================================
+ Coverage 73.36% 73.38% +0.02%
==========================================
Files 32 32
Lines 2440 2435 -5
==========================================
- Hits 1790 1787 -3
+ Misses 540 539 -1
+ Partials 110 109 -1
Continue to review full report at Codecov.
|
| @@ -224,7 +232,7 @@ func (a *App) Run(arguments []string) (err error) { | |||
|
|
|||
| err = parseIter(set, a, arguments[1:], shellComplete) | |||
| nerr := normalizeFlags(a.Flags, set) | |||
| context := NewContext(a, set, nil) | |||
| context := NewContext(a, set, &Context{Context: ctx}) | |||
There was a problem hiding this comment.
Will this still work of user does RunWithContext(nil, args)
There was a problem hiding this comment.
Passing a nil Context is always a developer error.
Do not pass a nil Context, even if a function permits it. Pass context.TODO if you are unsure about which Context to use.
We shouldn't need to support that
rliebz
reviewed
Dec 5, 2019
|
@rliebz @AudriusButkevicius PR updated :) |
rliebz
approved these changes
Dec 6, 2019
AudriusButkevicius
approved these changes
Dec 6, 2019
This was referenced Dec 8, 2019
Merged
This was referenced May 21, 2021
Closed
This was referenced Jun 1, 2021
Closed
This was referenced Jun 6, 2021
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #945