Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: take unique into account when counting with sqlalchemy #791

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lqmanh
Copy link

@lqmanh lqmanh commented Aug 17, 2023

My proposal to resolve #674

Given that we already have unique: bool param and use it when resolving items, it makes sense to apply it when counting as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Total returns more values than expected (not applying distinct on count)
1 participant