Upgrade coverage to 4.5.2 #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1495 +/- ##
==========================================
+ Coverage 69.53% 100% +30.46%
==========================================
Files 22 22
Lines 2685 1854 -831
==========================================
- Hits 1867 1854 -13
+ Misses 818 0 -818
Continue to review full report at Codecov.
|
sethmlarson
changed the title
|
Ah, yes, of course! I've seen this in python-trio/trio#784 too but for some reason did not make the connection here. Nice catch. |
|
@theacodes If you've got time this PR would help us out a lot. :) |
theacodes
approved these changes
Jan 11, 2019
pquentin
added a commit
to pquentin/hip
that referenced
this pull request
Oct 29, 2019
It was introduced in urllib3/urllib3#875, but since urllib3/urllib3#1495 twine is no longer a dev requirement.
Dobatymo
pushed a commit
to Dobatymo/urllib3
that referenced
this pull request
Mar 16, 2022
Dobatymo
pushed a commit
to Dobatymo/urllib3
that referenced
this pull request
Mar 16, 2022
It was introduced in urllib3#875, but since urllib3#1495 twine is no longer a dev requirement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out per nedbat/coveragepy#714 that phantom lines are generated when running on Python 3.8, that's probably the root of our issues? If you check the report on codecov for this PR it's at 100% now. :)