-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hardcoded paths to macOS frameworks for Big Sur compatibility. #1905
Merged
Commits on Jul 16, 2020
-
Add hardcoded paths to macOS frameworks for Big Sur compatibility.
ctypes.util.find_library is checking for the presence of the framework files, which will fail due to macOS Big Sur's "dynamic linker cache". Since these files really can't be anywhere else, we just hardcode the path and load them. See: https://developer.apple.com/documentation/macos-release-notes/macos-big-sur-11-beta-release-notes (relevent excerpt provided below) This update takes the approach of leaving the existing behavior as is for macOS 10.8 (lowest supported version) through 10.15. Allegedly Apple is going to number Big Sur as macOS 11, although right now the beta returns a version of "10.16", so this code handles both as being greater than or equal to "10.16". | New in macOS Big Sur 11 beta, the system ships with a built-in dynamic linker cache of all system-provided libraries. As part of this change, copies of dynamic libraries are no longer present on the filesystem. Code that attempts to check for dynamic library presence by looking for a file at a path or enumerating a directory will fail. Instead, check for library presence by attempting to dlopen() the path, which will correctly check for the library in the cache. (62986286)
Configuration menu - View commit details
-
Copy full SHA for 3e003a7 - Browse repository at this point
Copy the full SHA 3e003a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for c3d5e56 - Browse repository at this point
Copy the full SHA c3d5e56View commit details -
Just use hardcoded paths for Security and CoreFoundation libs.
This should never be anything but these paths. Instead of checking for `os.path.isfile` with `ctypes.util.find_library`, we just try to load with `ctypes.CDLL` and catch the `OSError` if it fails, add context, and reraise.
Configuration menu - View commit details
-
Copy full SHA for 895f11f - Browse repository at this point
Copy the full SHA 895f11fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6508362 - Browse repository at this point
Copy the full SHA 6508362View commit details
Commits on Jul 17, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 0f8d2fa - Browse repository at this point
Copy the full SHA 0f8d2faView commit details
Commits on Jul 19, 2020
-
Configuration menu - View commit details
-
Copy full SHA for f63062b - Browse repository at this point
Copy the full SHA f63062bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5efec6a - Browse repository at this point
Copy the full SHA 5efec6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 43416bc - Browse repository at this point
Copy the full SHA 43416bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for d57db89 - Browse repository at this point
Copy the full SHA d57db89View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.