Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add max_retry_wait_lenght to Retry #2727

Closed
wants to merge 2 commits into from
Closed

Add max_retry_wait_lenght to Retry #2727

wants to merge 2 commits into from

Conversation

sobelek
Copy link
Contributor

@sobelek sobelek commented Aug 25, 2022

This PR Fixes #1338
I have reused some of the initial implementation from #1587

sobelek
sobelek commented Aug 25, 2022
View reviewed changes
test/tz_stub.py Outdated Show resolved Hide resolved
@sobelek
Copy link
Contributor Author

sobelek commented Sep 3, 2022

@sethmlarson
Hey :)
Any chance for review?

@sethmlarson
Copy link
Member

Thanks for opening this PR, however I'm of the opinion that we shouldn't continuously add functionality to what was originally a mostly simply Retry class. I'd like to rethink what retries mean in urllib3 and adding new functionality here won't make that easier. Going to close this for now until we get v2.0 out and then we can start discussing this larger topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Retry.get_retry_after does't respect time-out
2 participants
@sobelek @sethmlarson