Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable tunnel for http2 requests #3321

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Disable tunnel for http2 requests #3321

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6a44293
Disable tunnel for http2
Nightrider0098 Jan 25, 2024
1949484
Fix lints
Nightrider0098 Jan 25, 2024
c889806
Move checks below
Nightrider0098 Jan 26, 2024
e0bef9d
Add checks to disable tunnel in h2
Nightrider0098 Feb 8, 2024
be61dfa
Resolve comments
Nightrider0098 Feb 8, 2024
974b693
Merge master
Nightrider0098 Feb 8, 2024
c8406a4
Fix master merge
Nightrider0098 Feb 8, 2024
60d6fd5
add end line
Nightrider0098 Feb 8, 2024
47d695f
Resolve comments
Nightrider0098 Feb 8, 2024
a061b91
Resolve comments
Nightrider0098 Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/urllib3/http2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ def __init__(
if "proxy" in kwargs or "proxy_config" in kwargs: # Defensive:
raise NotImplementedError("Proxies aren't supported with HTTP/2")

if self._tunnel_host is not None:
raise NotImplementedError("Tunneling isn't supported with HTTP/2")

super().__init__(host, port, **kwargs)

@contextlib.contextmanager
Expand Down