Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Measure coverage with v4 of artifact actions #3394

Merged
merged 2 commits into from
May 13, 2024
Merged

Measure coverage with v4 of artifact actions #3394

merged 2 commits into from
May 13, 2024

Conversation

pquentin
Copy link
Member

As explained in the update of https://hynek.me/articles/ditch-codecov-python/

@pquentin pquentin added the Skip Changelog Pull requests that don't require a changelog entry label May 13, 2024
sethmlarson
sethmlarson previously approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Quentin! :)

@pquentin pquentin requested a review from sethmlarson May 13, 2024 17:54
@pquentin
Copy link
Member Author

Thanks! I fixed a typo and the step works now: https://github.com/urllib3/urllib3/actions/runs/9067260304/job/24912787034?pr=3394

illia-v
illia-v approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@illia-v illia-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pquentin pquentin merged commit b8589ec into urllib3:main May 13, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illia-v illia-v illia-v approved these changes

@shazow shazow Awaiting requested review from shazow shazow is a code owner

@sethmlarson sethmlarson Awaiting requested review from sethmlarson sethmlarson is a code owner

Assignees
No one assigned
Labels
Skip Changelog Pull requests that don't require a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pquentin @illia-v @sethmlarson