New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hot Reloading Examples page #1090
Conversation
Size Change: +2 B (0%) Total Size: 24.2 kB
ℹ️ View Unchanged
|
| */ | ||
module.exports = { | ||
"ui": false, | ||
"files": ['dist/**', 'example/**', 'docs/**', 'themes/**'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm planning on moving the examples/ folder to introjs-website repo. I think we should keep this repo for Intro.js codebase and the introjs-website
for docs, examples, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I was wondering about that. That makes this whole PR dead. I can make new instructions once those changes are made I guess. We could run rollup -c -w in this repo, and then browsersync in the website, with yarn link or something? Cool to close this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually what happens with the netlify deploys if the example dir is moved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good question. I did not consider the Netilfy deploys 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git sub-modules? 😨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if there are any good solutions. Symlinking and string replacements (for URL's) come to my mind. I guess it's a good question as to what the examples pages are for. Are they for the website? or for development?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
both? I thing the end goal is to have the examples folder on the website but it's also nice to have that folder in the main repo (helps with Netlify deployments as you mentioned).
adds: