fix: requires selected account for interaction to be available #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vailable in the current keyring
✅ Deploy Preview for contracts-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Passing run #399 ↗︎
Details:
Review all test suite changes for PR #552 ↗︎ |
||||||||||||||||||||
ascjones
reviewed
Apr 10, 2024
ascjones
approved these changes
Apr 11, 2024
peetzweg
deleted the
458-ui-remains-in-processing-state-when-there-is-a-keyring-error
branch
Passing run #401 ↗︎
Details:
Review all test suite changes for PR #552 ↗︎ |
||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #458 .
As our
AccountSelectallows for creating new select options on the fly, the user can create new options which are not available to sign a deployment or a contract call extrinsic. I added a second layer validation of this value in the deploy and interaction of contracts.Disabling the creation of options on the fly is not what we want, as this component is used as a general account input. In this case we want to offer the user to select known accounts but also put it any valid account id.
The demo shows the error first on the latest deployed version of
contracts-uiand later the behavior with the changes in this branch.demo24.mov