fix: removes unecessary encoding of salt during dryrun #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for contracts-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Passing run #395 ↗︎
Details:
Review all test suite changes for PR #553 ↗︎ |
|||||||||||||||
ascjones
approved these changes
Apr 10, 2024
Passing run #397 ↗︎
Details:
Review all test suite changes for PR #553 ↗︎ |
||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #382.
The ui was encoding the salt during dryrunning the instantiate of contracts but not during the actual instantiation. Therefore the contract address shown from the dry run result was not matching the actual deployed contract address.
Video showing the bug before and after fix:
demo24.mov
Can be tested on the deploy preview.