Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly handle DNS lookup on localhost, and fallback if needed #1140

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

BrandonGillis
Copy link
Contributor

Description

This PR is the following of #1136, this should work as the previous PR @helloanoop even though I did some refactoring.

what changed :

  • removed the connectivity cache if it fail, this allow handling edge case like :

    • my localhost server is stopped, I do a request with bruno (fail), I start my server, do a request with bruno (success)
  • added dns.lookup first if localhost resolve to a special IP, check the connectivity, and fallback to the custom handling if needed.

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

@BrandonGillis BrandonGillis mentioned this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant