Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interpolate vars correctly in graphql introspection request #2317

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Jackevansevo
Copy link

@Jackevansevo Jackevansevo commented May 15, 2024

Description

It looks like there was regression with the graphql introspection query code that was preventing pre-request scripts from settings header values in the prepared request.

#704

Using an example here, a pre-script that sets some authentication headers

Screenshot 2024-05-15 at 17 20 59

This data now actually gets sent through to the backend

X-Mul-Nonce: xxxx
X-Mul-Timestamp: xxxx
X-Mul-Signature: xxxxx

So my (previously broken) introspection request now succeeds.

Screenshot 2024-05-15 at 17 21 14

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

@Jackevansevo Jackevansevo changed the title interpolate vars correctly interpolate vars correctly in graphql introspection request May 15, 2024
@Jackevansevo Jackevansevo force-pushed the interpolate-request-vars-correctly-in-graphql-introspection branch from 3cbfd99 to 27a82d9 Compare May 15, 2024 16:24
@helloanoop
Copy link
Contributor

@lohxt1 Can you review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants