fix: multipart formdata interpolation #2321
Open
+64
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lohxt1
changed the title
Its-treason
reviewed
May 16, 2024
| @@ -186,6 +195,12 @@ const runSingleRequest = async function ( | |||
| request.data = qs.stringify(request.data); | |||
| } | |||
|
|
|||
| if (request.headers['content-type'] === 'multipart/form-data' && !request.__bruno__bodySetViaMethodCall) { | |||
There was a problem hiding this comment.
Instead of checking of the Body was set inside a script. Wouldn't it be better to check if the body is already a FormData object?
What if a user has a script like this:
const originalBody = req.getBody();
const calculated = 'Imagine this is calculated';
req.setBody({
...originalBody,
'script-val': calculated,
})Now the plain object is sent to the server.
Its-treason
reviewed
May 16, 2024
| extend(axiosRequest.headers, form.getHeaders()); | ||
| axiosRequest.data = form; | ||
| each(enabledParams, (p) => (params[p.name] = p.value)); | ||
| axiosRequest.data = params; |
There was a problem hiding this comment.
This introduces the same breaking change from my PR, where req.body becomes a plain Key-Value object instead of a FormData object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
~ multipart formdata interpolation
~ also considers scenarios when the body is set using a pre-request script
multipart-form-data-interpolation.mov
_multipart-form-data-interpolation-cli.mp4