Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated tags list UI #3310

Closed
wants to merge 1 commit into from
Closed

feat: updated tags list UI #3310

wants to merge 1 commit into from

Conversation

MehadND
Copy link
Contributor

@MehadND MehadND commented May 5, 2024

This PR addresses the issue raised in #3288.

Modified the UI so that user can easily search tags.

Demo (old)

Memos.-.Google.Chrome.2024-05-05.22-15-59.mp4

@MehadND
Copy link
Contributor Author

MehadND commented May 5, 2024

Did not test with subtags (as I didn't know how to make them) so please feel free to test with it.

@MehadND MehadND marked this pull request as ready for review May 5, 2024 09:21
@MehadND MehadND requested a review from boojack as a code owner May 5, 2024 09:21
Copy link
Collaborator

@michaelien michaelien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could we have some screenshots about the UI part

web/src/components/HomeSidebar/TagsSection.tsx Outdated Show resolved Hide resolved
@MehadND
Copy link
Contributor Author

MehadND commented May 5, 2024

Few Screenshots of UI:

image

image

@MehadND MehadND force-pushed the tags branch 2 times, most recently from ef409fc to 26b2662 Compare May 6, 2024 14:32
@kbiits
Copy link
Contributor

kbiits commented May 6, 2024

Should we care about the subtags?? I think this PR will make the subtags not displayed

@MehadND
Copy link
Contributor Author

MehadND commented May 6, 2024

Should we care about the subtags?? I think this PR will make the subtags not displayed

I mean we should but problem is I don't know how to create subtags and therefore I can't integrate them in this PR. But if you do please do contribute to this PR or at least guide me.

@kbiits
Copy link
Contributor

kbiits commented May 6, 2024

@MehadND Just add / in your tag to make it a subtag. Ex: #parent/sub1. sub1 is a child of parent.
Please look at screen capture here

@MehadND
Copy link
Contributor Author

MehadND commented May 7, 2024

@MehadND Just add / in your tag to make it a subtag. Ex: #parent/sub1. sub1 is a child of parent.

Please look at screen capture here

@kbiits @boojack is there any chance where we can just render the tags and their subtags all together. Like in a long list of tags.

Are subtags just for organisation reasons only or is there any other reason for their use case?

I was thinking just display tags and subtags together and you can just search the tag for filtering.

Anyways what do you guys think?

@boojack
Copy link
Collaborator

boojack commented May 7, 2024

is there any chance where we can just render the tags and their subtags all together. Like in a long list of tags.

SGTM, updated with d355e2c

@boojack
Copy link
Collaborator

boojack commented May 10, 2024

The main branch makes a lot of changes to tags, and there are conflicts in this PR, so let's close it first.

@boojack boojack closed this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants