New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: updated tags list UI #3310
Conversation
Did not test with subtags (as I didn't know how to make them) so please feel free to test with it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Could we have some screenshots about the UI part
ef409fc
to
26b2662
Compare
Should we care about the subtags?? I think this PR will make the subtags not displayed |
I mean we should but problem is I don't know how to create subtags and therefore I can't integrate them in this PR. But if you do please do contribute to this PR or at least guide me. |
@MehadND Just add |
@kbiits @boojack is there any chance where we can just render the tags and their subtags all together. Like in a long list of tags. Are subtags just for organisation reasons only or is there any other reason for their use case? I was thinking just display tags and subtags together and you can just search the tag for filtering. Anyways what do you guys think? |
SGTM, updated with d355e2c |
The main branch makes a lot of changes to tags, and there are conflicts in this PR, so let's close it first. |
This PR addresses the issue raised in #3288.
Modified the UI so that user can easily search tags.
Demo (old)
Memos.-.Google.Chrome.2024-05-05.22-15-59.mp4