Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): include device pixel ratio in w/h calculation #199

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

userquin
Copy link
Owner

@userquin userquin commented Feb 20, 2024

There is a problem with Chrome running on Android, sending weird viewport size.

We need to request device pixel ratio (Sec-CH-DPR) to calculate the right width/height.

WICG/responsive-image-client-hints#23

https://twitter.com/userquin/status/1760047138762064277

Using Samsumg Galaxy S22 Ultra:

GGzwwW1awAASbQt

related #197

Copy link

netlify bot commented Feb 20, 2024

Deploy Preview for vuetify-nuxt-module ready!

Name Link
🔨 Latest commit 3db7875
🔍 Latest deploy log https://app.netlify.com/sites/vuetify-nuxt-module/deploys/65df47c136c62800088bf93c
😎 Deploy Preview https://deploy-preview-199--vuetify-nuxt-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@userquin userquin marked this pull request as draft February 21, 2024 12:06
@userquin userquin changed the title fix: change SSR client hints server plugin order fix(ssr): include device pixel ratio in w/h calculation Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant