feat mongo: Added Get/Set batch size for Mongo Cursor #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botanegg
commented
Jun 21, 2023
| @@ -15,6 +15,10 @@ Cursor& Cursor::operator=(Cursor&&) noexcept = default; | |||
|
|
|||
| bool Cursor::HasMore() const { return impl_->IsValid(); } | |||
|
|
|||
| uint32_t Cursor::GetBatchSize() const { return impl_->GetBatchSize(); } | |||
|
|
|||
| void Cursor::SetBatchSize(uint32_t size) { impl_->SetBatchSize(size); } | |||
There was a problem hiding this comment.
Idea: Changing signature to Cursor & and return *this makes possible to write chaining methods like:
auto cursor = collection.Find(filter).SetBatchSize(N);
It is similar to mongo example syntax or Mongo Golang driver (StackOverflow)
|
Looks very good. Please add some tests |
|
It needs time to understand how utest and mongotest works :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to get/set batchSize for mongo::Cursor