Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msys2 -> msys2.portable #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

galeksandrp
Copy link

@galeksandrp galeksandrp commented Nov 9, 2016

Discussing with @gep13 there

@userzimmermann userzimmermann self-assigned this Nov 11, 2016
@userzimmermann userzimmermann changed the base branch from master to msys2 November 27, 2016 00:36
@userzimmermann userzimmermann changed the base branch from msys2 to master November 27, 2016 00:37
@userzimmermann userzimmermann changed the base branch from master to msys2 November 27, 2016 00:41
@userzimmermann userzimmermann changed the base branch from msys2 to master November 27, 2016 00:43
@gep13
Copy link

gep13 commented Dec 7, 2016

@galeksandrp @userzimmermann just wanted to touch base on this to see what you guys had decided to do. Thanks!

@userzimmermann
Copy link
Owner

@gep13 @galeksandrp Hi. I'm fine with your plan. I already merged these changes locally to msys2 branch and will make new releases the next days.

@galeksandrp Do you want to become co-maintainer of the meta package?

Cheers,
Stefan

@gep13
Copy link

gep13 commented Dec 8, 2016

Perfect. Please let me know if there is anything else that you need help with.

@galeksandrp
Copy link
Author

@userzimmermann Did you made new release?

@yad-repo
Copy link

Hi. What do you think about msys2-installer Chocolatey package? I have followed similar concept than @galeksandrp with added uninstall script and few other minor changes. I also plan to release all versions that are available up to date (20150916, 20160205, 20160921, 20161025).

@galeksandrp
Copy link
Author

@gep13 I think @yad-repo package should supersede mine. What do you think?

@AdmiringWorm
Copy link

@galeksandrp
I think the preferred way would be to update the msys.install package (you could perhaps add @yad-repo as a co-maintainer) and change the msys package to a meta package (extract all the existing logic of that into a msys.portable package and having msys package depend on msys.portable (or msys.install if preferred))

That would be the correct naming convention for virtual/meta packages.

/cc @userzimmermann @gep13

@gep13
Copy link

gep13 commented Mar 9, 2017

Sounds like a plan to me! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants