-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend the memo feature with optional parameters for expiring entries #1424
Merged
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
990d9ae
Implemented new, configurable version of memo
DavyLandman ac7210c
Updated test to actually work
DavyLandman 66df71a
Change expire syntax of the memo config to:
DavyLandman 5cf44d3
Now we use a nice adt for configuring the memo feature
DavyLandman a3bf54d
Reduce the amount of cleanups
DavyLandman cefdc7e
Added possibility to combine expiration options
DavyLandman 0d048e1
Fixed mixed tabs and spaces
DavyLandman 7cb2297
Last comments added to ticker class
DavyLandman 953260f
Simplified code
DavyLandman 2fed9a6
Simplified code based on discussions
DavyLandman e9ebeb4
Fixed npe in keyargs
DavyLandman 0239e48
Refactoring of class names
DavyLandman effaff7
Refactored to using a thread local for lookup
DavyLandman de10cec
Use result of store
DavyLandman File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What an incredible thorough and nice blog post! TIL :)