Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub Actions for Surge push #1468

Merged
merged 3 commits into from
Dec 3, 2022
Merged

Conversation

wd15
Copy link
Collaborator

@wd15 wd15 commented Dec 2, 2022

Switch the Surge push to use GitHub Actions.

Fixes #1429

The push occurs with an event that does not use a pull_request trigger, but a workflow_run trigger. This needed to be tested from master, not a pull request, see the new surge.yml file on master. The pullrequest.yml file on this branch triggers the surge.yml workflow.

  • The comment back to the PR can be seen below.
  • I don't know how to update the Surge token (the current one is exposed), see Revoke token sintaxi/surge#491
  • The Nix Cache has been fixed and actually works now
  • The Surge teardown will be implemented in a separate PR

Replaces #1467 as had issues rebasing.

Remember to tear down the live site when merging or closing this
pull request.

New action to trigger actions that want to know about a pull
request. Pull request actions don't get access to secrets so actions
need to be run from a workflow_run event. This is to help with the
Surge push.
Surge push now occurs in a GitHub action.
@pfhub
Copy link
Collaborator

pfhub commented Dec 2, 2022

@wd15, the new version of the PFHub website is available at https://random-cat-1468.surge.sh

@wd15 wd15 requested a review from tkphd December 2, 2022 18:33
@wd15 wd15 added this to the April 2023 Meeting milestone Dec 2, 2022
Copy link
Collaborator

@tkphd tkphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I'm no expert on workflow scripting.

@wd15 wd15 merged commit c055b6f into usnistgov:master Dec 3, 2022
@pfhub
Copy link
Collaborator

pfhub commented Dec 3, 2022

Successful teardown of random-cat-1468.surge.sh

@wd15 wd15 deleted the issue1429-surge-update branch December 5, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use GitHub action for PR comment about Surge
3 participants