Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS - Bug: Banner & Footer style conflict caused by removing layout-grid dependency. #5914

Closed
2 tasks done
mahoneycm opened this issue May 6, 2024 · 0 comments · Fixed by #5930
Closed
2 tasks done
Assignees
Labels
Added during Sprint Context: Sass Issue is in Sass Package: Footer Role: Dev Development/engineering skills needed Type: Bug A problem in the code
Milestone

Comments

@mahoneycm
Copy link
Contributor

Describe the bug

When forwarding usa-banner & usa-footer packages and not the usa-layout-grid package, there are visual regressions within the banner.

This is caused by the new layout grid styles added to the footer stylesheet in #5675

Steps to reproduce the bug

  1. Add banner and footer to a page.
  2. Remove all other packages or @forward "uswds" from styles.scss file.
  3. Only import usa-banner & usa-footer.
  4. Compile and inspect display of the banner component.

Expected Behavior

Banner and footer should display as expected without forwarding the layout grid package

Related code

styles.scss

@forward "uswds-theme";
@forward "usa-banner";
@forward "usa-footer";
@forward "uswds-theme-custom-styles";

This seems to be the definition that is causing the visual regression

// Columns
[class*="grid-col"] {
@include u-position(relative);
@include u-width(full);
box-sizing: border-box;
}

Screenshots

image

System setup

No response

Additional context

No response

Code of Conduct

@mahoneycm mahoneycm added Type: Bug A problem in the code Needs: Confirmation We need to confirm that this is an issue labels May 6, 2024
@github-actions github-actions bot added the Status: Triage We're triaging this issue and grooming if necessary label May 6, 2024
@brunerae brunerae added this to the uswds 3.8.1 milestone May 9, 2024
@brunerae brunerae removed the Status: Triage We're triaging this issue and grooming if necessary label May 9, 2024
@mahoneycm mahoneycm added Context: Sass Issue is in Sass Package: Footer Role: Dev Development/engineering skills needed Added during Sprint and removed Needs: Confirmation We need to confirm that this is an issue labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added during Sprint Context: Sass Issue is in Sass Package: Footer Role: Dev Development/engineering skills needed Type: Bug A problem in the code
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants