USWDS - Footer: Restore layout-grid dependency #5930
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Restored layout-grid dependency in footer package and removed layout-grid styles from footer stylesheet. This update prevents visual regression in other components with layout-grid utility classes in their markup.
Breaking change
This is not a breaking change.
Related issue
Closes #5914
Related pull requests
Changelog →
USWDS - Footer: Remove grid dependency.#5289
USWDS - Footer: Grid layout hotfix#5675
Preview link
Footer storybook preview →
Problem statement
The styles we added to footer after removing the layout-grid dependency cause visual regressions in other components with layout-grid utility classes in their markup.
Solution
Due to the amount of layout-grid classes used in footer markup, we’ve decided it’s best to include the dependency moving forward.
Major changes
layout-grid
dependency in footer packagelayout-grid
classes in footer stylesheetTesting and review
usa-layout-grid
package._usa-footer.scss
to the release-3.7.0 version (before we removed the dependency) and confirm they match.