Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS - Footer: Restore layout-grid dependency #5930

Merged
merged 1 commit into from
May 22, 2024

Conversation

mahoneycm
Copy link
Contributor

@mahoneycm mahoneycm commented May 15, 2024

Summary

Restored layout-grid dependency in footer package and removed layout-grid styles from footer stylesheet. This update prevents visual regression in other components with layout-grid utility classes in their markup.

Breaking change

This is not a breaking change.

Related issue

Closes #5914

Related pull requests

Changelog →

USWDS - Footer: Remove grid dependency.#5289

USWDS - Footer: Grid layout hotfix#5675

Preview link

Footer storybook preview →

Problem statement

The styles we added to footer after removing the layout-grid dependency cause visual regressions in other components with layout-grid utility classes in their markup.

Solution

Due to the amount of layout-grid classes used in footer markup, we’ve decided it’s best to include the dependency moving forward.

Major changes

  • Restored layout-grid dependency in footer package
  • Removed layout-grid classes in footer stylesheet
  • Footer package size before: 4 kb
  • Footer package size after: 12 kb

Testing and review

  1. Visit the footer component and it’s variant pages
  2. Confirm there is no visual regression in any viewport widths
  3. Inspect demo repo code and preview
  4. Confirm that banner and footer are displaying as expected without the usa-layout-grid package.
  5. Compare _usa-footer.scss to the release-3.7.0 version (before we removed the dependency) and confirm they match.
  6. Confirm that there were no other updates to footer styles that are missing.

@mahoneycm mahoneycm marked this pull request as ready for review May 15, 2024 18:57
@mahoneycm mahoneycm changed the title Restore grid dependency and styles USWDS - Footer: Restore layout-grid dependency May 15, 2024
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I checked the following:

@thisisdano thisisdano merged commit e9bd88e into develop May 22, 2024
5 checks passed
@thisisdano thisisdano deleted the cm-footer-restore-grid-dep branch May 22, 2024 22:37
@thisisdano thisisdano mentioned this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

USWDS - Bug: Banner & Footer style conflict caused by removing layout-grid dependency.
4 participants