GH-433: Empty embeds if game board does not use them

utarwyn · Feb 15, 2023 · f7c1582 · f7c1582
1 parent db9b5c2
commit f7c1582
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 6 deletions.
diff --git a/src/__tests__/GameBoardBuilder.test.ts b/src/__tests__/GameBoardBuilder.test.ts
@@ -21,7 +21,8 @@ describe('GameBoardBuilder', () => {
         expect(builder.toMessageOptions()).toEqual({
             allowedMentions: { parse: ['users'] },
             content: '',
-            components: []
+            components: [],
+            embeds: []
         });
     });
 
@@ -88,7 +89,7 @@ describe('GameBoardBuilder', () => {
     it('should set state based if game has expired', () => {
         builder.withExpireMessage();
         expect(builder.toMessageOptions()).toEqual(
-            expect.objectContaining({ content: 'game.expire', embeds: undefined })
+            expect.objectContaining({ content: 'game.expire', embeds: [] })
         );
     });
 

diff --git a/src/__tests__/GameBoardButtonBuilder.test.ts b/src/__tests__/GameBoardButtonBuilder.test.ts
@@ -18,7 +18,7 @@ describe('GameBoardButtonBuilder', () => {
     });
 
     it('should send empty message by default', () => {
-        expect(builder.toMessageOptions()).toEqual({ content: '', components: [] });
+        expect(builder.toMessageOptions()).toEqual({ content: '', components: [], embeds: [] });
     });
 
     it('should compute board components', () => {
@@ -66,7 +66,7 @@ describe('GameBoardButtonBuilder', () => {
         ${{ toString: () => 'fake' }} | ${'fake, select your move:'}
     `('should set state based if playing entity is $entity', ({ entity, state }) => {
         builder.withEntityPlaying(entity);
-        expect(builder.toMessageOptions()).toEqual({ content: state, components: [] });
+        expect(builder.toMessageOptions()).toEqual({ content: state, components: [], embeds: [] });
     });
 
     it('should compute board using disabled buttons after been used', () => {

diff --git a/src/bot/builder/GameBoardBuilder.ts b/src/bot/builder/GameBoardBuilder.ts
@@ -175,7 +175,7 @@ export default class GameBoardBuilder {
             allowedMentions: { parse: ['users'] },
             embeds: this.embedColor
                 ? [{ title: this.title, description: board + state, color: this.embedColor }]
-                : undefined,
+                : [],
             content: !this.embedColor ? this.title + board + state : undefined,
             components: []
         };

diff --git a/src/bot/builder/GameBoardButtonBuilder.ts b/src/bot/builder/GameBoardButtonBuilder.ts
@@ -97,7 +97,7 @@ export default class GameBoardButtonBuilder extends GameBoardBuilder {
         return {
             embeds: this.embedColor
                 ? [{ title: this.title, description: this.state, color: this.embedColor }]
-                : undefined,
+                : [],
             content: !this.embedColor ? this.title + this.state : undefined,
             components: [...Array(this.boardSize).keys()].map(row =>
                 new MessageActionRow().addComponents(