Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-56: Customize option name for slash command #160

Merged
merged 1 commit into from Jan 24, 2022

Conversation

utarwyn
Copy link
Owner

@utarwyn utarwyn commented Jan 24, 2022

Description

Using slash command is now supported in the module. In the first version I used opponent as the option to provide the name of an user to play with. It seems legit to provide you a way to customize this name and put your own if wanted.

This PR brings that support. You must reload your command using ?tttdeploy after each change.

New configuration option

Module versionning Option name
v3.x.x commandOptionName
v2.2.x slashCommandOptionName

Example

Here is an example on how to rename it player using v2.2.x:

{
    "slashCommandOptionName": "player"
}

And how it looks after deployed:

image

馃寕Closes #56
馃殌 Will be available from v2.2.x and v3.0.0.

@utarwyn utarwyn added the type: enhancement Features and feature requests. label Jan 24, 2022
@utarwyn utarwyn added this to the 2.2.x milestone Jan 24, 2022
@utarwyn utarwyn self-assigned this Jan 24, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jan 24, 2022

Kudos, SonarCloud Quality Gate passed!聽 聽 Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@utarwyn utarwyn merged commit c17d275 into release/2.x Jan 24, 2022
@utarwyn utarwyn deleted the issue-56-custom-command-option-name branch January 24, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Features and feature requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant