Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to djs@14 #276

Merged
merged 3 commits into from Jul 27, 2022
Merged

Update to djs@14 #276

merged 3 commits into from Jul 27, 2022

Conversation

Gorniaky
Copy link
Contributor

@Gorniaky Gorniaky commented Jul 8, 2022

discord.js dependency updated to v14.0.0-dev.1657152699-10ba008

Tests
image
image

@Gorniaky
Update to djs@v14-dev
d8ea4d0 
> discord.js dependency updated to v14.0.0-dev.1657152699-10ba008
@utarwyn utarwyn added type: enhancement Features and feature requests. status: blocked Issues that are blocked for now. labels Jul 12, 2022
@utarwyn
Copy link
Owner

utarwyn commented Jul 12, 2022

Thank you for this great contribution! 💯 I am very grateful for your work on the adaptation for discord.js v14.
But I can't merge it for now, because you are using a development version. Based on your commit, this version seems to break some of the module code, so I think we will have to create a version 4 of the module.

@Gorniaky Gorniaky changed the title Update to djs@v14-dev Update to djs@14 Jul 19, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@utarwyn utarwyn mentioned this pull request Jul 21, 2022
Closed
@utarwyn utarwyn linked an issue Jul 21, 2022 that may be closed by this pull request
Add support for discord.js v14 #287
Closed
@utarwyn utarwyn removed the status: blocked Issues that are blocked for now. label Jul 21, 2022
@jebediah47
Copy link

jebediah47 commented Jul 21, 2022 •
edited

The code looks good for me and it seems it has been updated to the upstream discord.js v14 official version. The choice is up to the repository owner.

@utarwyn utarwyn mentioned this pull request Jul 27, 2022
Closed
utarwyn
utarwyn approved these changes Jul 27, 2022
View reviewed changes
Copy link
Owner

@utarwyn utarwyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@utarwyn utarwyn merged commit 285f78b into utarwyn:next Jul 27, 2022
utarwyn added a commit that referenced this pull request Jul 27, 2022
@utarwyn
Fix lint problems after #276
d9aa97b
@utarwyn utarwyn mentioned this pull request Aug 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utarwyn utarwyn utarwyn approved these changes

Assignees
No one assigned
Labels
type: enhancement Features and feature requests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for discord.js v14
3 participants
@Gorniaky @utarwyn @jebediah47