Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get doc tests to pass without std and shrink build runs #614

Closed
wants to merge 2 commits into from
Closed

Get doc tests to pass without std and shrink build runs #614

wants to merge 2 commits into from

Conversation

KodrAus
Copy link
Member

@KodrAus KodrAus commented Aug 22, 2022

For #611

Our build requirements explode when new features are added. What we really want is just to make sure that each feature works independently, and that they all work together. This PR does that by avoiding using the feature powerset in CI. I've also made sure our doc tests actually work when the std feature is disabled.

@rrichardson
Copy link
Contributor

rrichardson commented Aug 25, 2022

It would appear that the --each-feature run fails on Windows. Presumably because the env vars don't evaluate the same way in powershell.
I pulled this branch into my six-seven-eight branch and broke out the windows-2019 into separate scripts.. it seems to have worked.

@KodrAus
Copy link
Member Author

KodrAus commented Aug 29, 2022

Thanks for carrying this forwards, I think that's fair to unblock V6-V8 support, I'll look at reducing the duplication asynchronously.

@KodrAus KodrAus closed this Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants