Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize test tooling #341

Merged
merged 7 commits into from
Dec 4, 2019
Merged

Modernize test tooling #341

merged 7 commits into from
Dec 4, 2019

Conversation

ctavan
Copy link
Member

@ctavan ctavan commented Oct 25, 2019 •
edited

Follow-up PR to #347

@ctavan
test: run CI in GitHub actions
d3a0c06
@ctavan
test: remove Travis.ci now that we have github actions
8da6bf7
@ctavan
test: run tests using jest instead of mocha
929aa35
@ctavan
chore: install prettier
e8cb0a0 
It's tedious to maintain a consistent formatting style in an open source
project and prettier does a pretty good job at enforcing a consistent
style. So let's make use of that!
@ctavan
chore: run eslint on examples as well
9312740
@ctavan ctavan changed the base branch from master to next December 3, 2019 22:51
@ctavan ctavan changed the title WIP Modernize test tooling Modernize test tooling Dec 3, 2019
@ctavan ctavan requested a review from broofa December 3, 2019 22:52
@ctavan
Copy link
Member Author

ctavan commented Dec 3, 2019

@broofa I'm not willing to maintain a consistent code formatting on my own that's why I propose to add prettier which, in my experience, does a pretty good job at maintaining consistent formatting.

Thanks to eslint-plugin-prettier it also plays rather well with eslint.

@ctavan ctavan mentioned this pull request Dec 3, 2019
Merged
4 tasks
@ctavan ctavan merged commit 2857dba into next Dec 4, 2019
@ctavan ctavan mentioned this pull request Dec 4, 2019
Merged
@ctavan ctavan deleted the modernize-test-tooling branch January 16, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@broofa broofa broofa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ctavan @broofa