feat: add UMD build to npm package #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No strong opinions on this. As long as it doesn't add to the maintenance headache I don't care much one way or the other. |
broofa
approved these changes
Jan 27, 2020
ctavan
force-pushed
the
remove-insecure-rng
branch
from
32e4e86
to
3a5842b
Compare
|
Thought about it again and I think it's an acceptable overhead for a feature that has been requested at least three times last year: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A request for this has popped up a number of times in the issues.
I'm still not sure whether I want to add this. It adds another 28kb to the npm package and I'm not sure whether it's worth supporting such a legacy use case.
Plus there are options like https://bundle.run/uuid@latest?name=uuid
What do you think @broofa ?