Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace broken image in README file #695

Merged
merged 7 commits into from Mar 13, 2023
Merged

Replace broken image in README file #695

merged 7 commits into from Mar 13, 2023

Conversation

yonifra
Copy link
Contributor

@yonifra yonifra commented Mar 12, 2023

Fix broken image for RunMD

The image that was linked to from the README.md file was broken in imgur. I replaced the URL to the correct one from GitHub

Fix broken image for RunMD
@yonifra yonifra changed the title Update README.md Replace broken image in README file Mar 12, 2023
Copy link
Member

@broofa broofa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yonifra Good catch. This is was an issue with the upstream https://github.com/broofa/runmd module, which I've fixed. I've updated this PR as follows:

  • Update runmd dependency
  • Fix prettier formatting issues
  • Fix broken build.sh script. (I guess npm@9 no longer supports the npm bin command. It appears the recommended approach to running locally installed CLIs is to use the npx command. attn: @ctavan)
  • Run npm run docs to update README.md file

@ctavan: Can you confirm the changes to build.sh don't break anything?

@ctavan
Copy link
Member

ctavan commented Mar 13, 2023

I think the change looks good, thank you for fixing!

@ctavan ctavan merged commit a571c94 into uuidjs:main Mar 13, 2023
@yonifra yonifra deleted the patch-1 branch March 14, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants