Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bigdecimal from 0.4.0 to 0.4.2 #6285

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

cakebaker
Copy link
Contributor

This PR bumps bigdecimal from 0.4.0 to 0.4.2 as a (partial?) solution for #6281. I didn't upgrade to 0.4.3 because it breaks a lot of seq tests and according to akubera/bigdecimal-rs#127 (comment) they will revert some of its changes in 0.4.4:

Version 0.4.3 changed the formatting in a way many people didn't like, so I'm changing formatting again for 0.4.4.

@BenWiederhake
Copy link
Collaborator

Looks good, tests are green except a single flake on CI:

---- test_install::test_install_and_strip stdout ----
run: /Users/runner/work/coreutils/coreutils/target/x86_64-apple-darwin/debug/coreutils install -s helloworld_macos helloworld_installed
thread 'test_install::test_install_and_strip' panicked at 'called `Result::unwrap()` on an `Err` value: Custom { kind: Other, error: "wait: Timeout of '30s' reached" }', tests/common/util.rs:1708:35

@BenWiederhake BenWiederhake merged commit 3637e08 into uutils:main Apr 28, 2024
67 of 68 checks passed
@cakebaker cakebaker deleted the bump_bigdecimal branch April 29, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants