Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: initialize dev containers #3928

Draft
wants to merge 5 commits into
base: v3
Choose a base branch
from
Draft

chore: initialize dev containers #3928

wants to merge 5 commits into from

Conversation

rschlaefli
Copy link
Member

@rschlaefli rschlaefli commented Oct 27, 2023


Generated summary (powered by Graphite)

TL;DR

This pull request adds a Dockerfile, devcontainer.json, and docker-compose.yml files to the project. It also includes a rules_devcontainer.yaml file for Traefik configuration. The changes enable the use of a development container with additional features and services.

What changed

  • Added a Dockerfile for the development container.
  • Added a devcontainer.json file for configuring the development container.
  • Added a docker-compose.yml file for defining the services in the development container.
  • Added a rules_devcontainer.yaml file for Traefik configuration.

How to test

  1. Clone the repository.
  2. Build the development container using the Dockerfile.
  3. Start the development container using the docker-compose.yml file.
  4. Verify that the container is running and all services are accessible.
  5. Test the functionality of the application within the development container.

Why make this change

  • The addition of a Dockerfile, devcontainer.json, and docker-compose.yml files allows for the use of a development container, which provides a consistent and isolated environment for development.
  • The inclusion of the rules_devcontainer.yaml file enables Traefik configuration, allowing for routing and load balancing of services within the development container.
  • These changes improve the development experience by providing a standardized and reproducible environment, making it easier to onboard new developers and ensuring consistent behavior across different development machines.

Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bridgecrew has found errors in this PR ⬇️

.devcontainer/Dockerfile Outdated Show resolved Hide resolved
.devcontainer/Dockerfile Outdated Show resolved Hide resolved
@cypress
Copy link

cypress bot commented Oct 27, 2023

2 failed and 3 flaky tests on run #1135 ↗︎

2 15 0 0 Flakiness 3

Details:

Merge 7d5ad89 into dada3da...
Project: klicker-uzh Commit: ec79f213e5 ℹ️
Status: Failed Duration: 05:28 💡
Started: Oct 27, 2023 9:25 PM Ended: Oct 27, 2023 9:30 PM
Failed  live-session-workflow.cy.ts • 1 failed test

View Output Video

Test Artifacts
Different live-session workflows > shows a possible workflow of running a session and answering questions Test Replay Output Screenshots
Failed  questions-workflow.cy.ts • 1 failed test

View Output Video

Test Artifacts
Create questions > creates a KPRIM question Screenshots
Flakiness  live-session-workflow.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Different live-session workflows > creates a session with one block Test Replay Output Screenshots
Flakiness  questions-workflow.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
Create questions > creates a multiple choice question Screenshots
Create questions > creates a new question, duplicates it and then deletes the duplicate again Screenshots

Review all test suite changes for PR #3928 ↗︎

@rschlaefli rschlaefli changed the title add initial draft files chore: dev containers Oct 27, 2023
@rschlaefli rschlaefli changed the title chore: dev containers chore: initialize dev containers Oct 27, 2023
@rschlaefli rschlaefli marked this pull request as draft October 28, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant