Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select updated subscription item by name rather than link #1006

Open
wants to merge 1,193 commits into
base: main
Choose a base branch
from

Conversation

real-v2rayB
Copy link

@real-v2rayB real-v2rayB commented Aug 5, 2023

Related issues:

  1. https://github.com/v2rayA/v2rayA/issues/986
  2. https://github.com/v2rayA/v2rayA/issues/555
  3. https://github.com/v2rayA/v2rayA/issues/187

The subscription items are essentially a list of <ServerName, Url> pairs, and for the current implementation, we’re trying to match the “Url” part when we update the subscription. This can lead to a situation like:

  • The vendor (service provider) changes its service url because it’s been blocked
  • V2RayA updates the subscription to get the list of servers (automatically & periodically)
  • V2RayA will not connect to the new server because it is an unrecognized, new url
  • V2RayA will keep the connection with the old (blocked) servers even though the subscription is updated
  • (worst case scenario) all the selected servers are blocked

The fix will help V2RayA to match the "ServiceName" part and update the server <ServiceName, Url> pair when subscription updates, then restart V2Ray to utilize the new servers.

Gaojianli and others added 30 commits February 17, 2022 19:28
MarksonHon and others added 26 commits April 8, 2023 14:25
* Add more flow and fix sni

* Set tcp settings header to none only for TCP network

* Clean v2rayTmpl.go and create antiPollution common

* Set flow only to tls and xtls on vless urls

* Restore back .lock files

* Set host and if it's empty set sni as host
* Persian Language Added

* Back to the original version and test it

* Update release_feat_v5.yml

* Update App.vue

* persian tranlation

* Update release_feat_v5.yml

* add fa Flag

* rename flagFile

---------

Co-authored-by: mzz <mzz@tuta.io>
* added xtls-rprx-vision & uTLS fingerprint

* removed node option openssl-legacy-provider

* removed node option openssl-legacy-provider

* update github action

* fix: vless id

---------

Co-authored-by: clheo <93776896+Cl-He-O@users.noreply.github.com>
@mzz2017
Copy link
Collaborator

mzz2017 commented Aug 12, 2023

使用节点名来更新是一个误伤较大的改动,甚至有的订阅里有多个节点具有同样的名字。

另外,保持旧的节点是因为有的人希望能保留它们,然而我知道这确实有一些需求是替换它们。

我知道这是一个很有用的改动,对一些人来说它解决了直接痛点,但正如我所举例,它会迎合一部分用户,并伤害另一部分用户。我认为这些改动需要更多讨论和思考。

@real-v2rayB
Copy link
Author

So, make it an option for each subscription.

@mzz2017
Copy link
Collaborator

mzz2017 commented Aug 19, 2023

@real-v2rayB Good idea. Is it easy to implement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet