Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change to resolve 0.0.0.0:2017 security issue #727

Open
wants to merge 1,090 commits into
base: main
Choose a base branch
from

Conversation

SaumyaBhushan
Copy link

@SaumyaBhushan SaumyaBhushan commented Nov 29, 2022

chore: fix ci
@cubercsl
Copy link
Contributor

Some distribution like openwrt should still listen 0.0.0.0, so this is a breaking change and we should tell the maintainers make some changes in their packages before a tag release.

@SaumyaBhushan
Copy link
Author

Right @cubercsl

@1715173329
Copy link
Member

Some distribution like openwrt should still listen 0.0.0.0

It's the default behavior on openwrt. However, docker users might not that like this change.

Copy link

@JamesMackerel JamesMackerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default config value changed to 127.0.0.1 from 0.0.0.0, clean and good

@SaumyaBhushan
Copy link
Author

@JamesMackerel . Is it ready to get merged or something else needs to be changed or discussed ?

@JamesMackerel
Copy link

I'm OK with it. Thank you!

@dramthy

This comment was marked as off-topic.

@mzz2017
Copy link
Collaborator

mzz2017 commented Dec 2, 2022

I don't think it's a good idea to change it, because a lot of people use it with remote management, such as in routers and servers without a desktop environment.

There are MAYBE some vulnerabilities. However, we should also carefully consider usage scenafios.

@JamesMackerel
Copy link

I don't think it's a good idea to change it, because a lot of people use it with remote management, such as in routers and servers without a desktop environment.

This modification only changes the default config value, users are free to set the program to listen to 0.0.0.0 or any address if they want. I think the only thing we have to be care of is to mention this change in release note.

@SaumyaBhushan
Copy link
Author

Hi @JamesMackerel @mzz2017 Any update on this PR?

@mzz2017
Copy link
Collaborator

mzz2017 commented Mar 24, 2023

@SaumyaBhushan Now you can set this in /etc/default/v2raya conveniently~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet