New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speeding up v8 heap snapshots #702
Commits on Jun 21, 2023
-
* Add "Speeding up V8 heap snapshots" blog post.
Commits on Jun 22, 2023
-
Apply suggestions from Rob Palmer
Co-authored-by: Rob Palmer <rpalmer57@bloomberg.net>
-
Commits on Jun 27, 2023
-
Apply suggestions from Joyee Cheung
Several fixes in accuracy, specially related to NODE_OPTIONS processing, coming from the code review. Also some writing improvements. Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
-
More clarifications of Node.js specific parts
When we tried to make the post less Node.js specific, we want a bit too far, as the parts related to --heapsnapshot-near-heap-limit are indeed Node.js specific. Provided more clarity on that.
Commits on Jun 28, 2023
-
More accurate description of --heapsnapshot-near-heap-limit implement…
…ation Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
-
More details of source position caching fix
The level of details in teh source position caching fix explanation was quite poor, not even explaining why the source line position was not cached. Expand it after proposal from Joyee Cheung.
-
Reduce ambiguity of development and production JS code reference
In previous version, we talked about "unoptimized development JS" and "optimized production JS", that could be misleading, as Joyee Cheung pointed out, because it could induce reader to think about JS runtime optimizations. So this change removes reference there to optimized/unoptimized JS to later detail how production source code is optimized using bundling and minification.
-
Rewrite description of V8 heap limit configuration.
In the original description, we wrongly state that the heap limit is set by V8 to be 1400MB. Instead of this, it was an application specific limit. Also clarify that, in the test case, hitting Out-Of-Memory would hint there was a leak. Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
Commits on Jul 12, 2023
-
Apply suggestions from Joyee code review
Many insightful improvements to the writing of heap snapshot optimizations blog post, that can be landed altogether. Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
-
Remove unneeded reference from heap snapshot optimization post
"And old friend" reference was for the ETW fix that I presented in a different blog post that is not even linked. And it is redundant as later I explain that this issue is similar to another one fixed in ETW. Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
-
Crop images to improve readability
The images in the v8 heap snapshot optimizations post were too much big, with lots of empty space that was not relevant and made it harder to read the contents. After cropping the images, not it is more focused on the information that matters.
-
Apply suggestions from @syg code review
Co-authored-by: Shu-yu Guo <syg@chromium.org>
-
Apply suggestions from @syg in pull request.
Manually apply suggestions that could not be applied directly from the GH UI.
-
-
Do not use specific names explaining the heap snapshot performance in…
…vestigation Following @syg recommendation, avoid explicit engineers reference while explaining the procedure to investigate the performance problem.
-
Remove sponsorship reference in heap optimizations post
V8 team is not sponsored. Work is actually done by engineers of different companies. Rewrite the credits section accordingly.
Commits on Jul 13, 2023
Commits on Jul 18, 2023
-
speeding-up-heap-snapshots.md: apply suggestions from Joyee code review
Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
-
Update speeding-up-v8-heap-snapshot.md: replace obscure reference to …
…previous post Originally the blog post was part of a series until it was proposed to be an independent post in v8.dev. Make the reference to the previous post independent of the fact by referring to the link of the previous post.
-
speeding-up-v8-snapshots.md: following recommendations from Joyee, si…
…mplified writing Several changes to reduce redundancies and simplify reading the post: - Remove step-by-step guide of using Windows Performance Recording, referring to upstream documentation now. - Snippets are now almost C++ code instead of pseudocode. - Some typos. - Simplified line break caching explanation, and removed reference to equivalent ETW fix.
-
Commits on Jul 19, 2023
-
speeding-up-v8-heap-snapshots.md: apply suggestions from @syg
Co-authored-by: Shu-yu Guo <syg@chromium.org>