Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speeding up v8 heap snapshots #702

Merged
merged 27 commits into from Jul 27, 2023

Commits on Jun 21, 2023

  1. Speeding up v8 heap snapshots

    * Add "Speeding up V8 heap snapshots" blog post.
    jdapena committed Jun 21, 2023
    Copy the full SHA
    7d91e99 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. Apply suggestions from Rob Palmer

    Co-authored-by: Rob Palmer <rpalmer57@bloomberg.net>
    jdapena and robpalme committed Jun 22, 2023
    Copy the full SHA
    485d04f View commit details
    Browse the repository at this point in the history
  2. Fix lint issues

    jdapena committed Jun 22, 2023
    Copy the full SHA
    3dbf61b View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2023

  1. Apply suggestions from Joyee Cheung

    Several fixes in accuracy, specially related to NODE_OPTIONS processing,
    coming from the code review. Also some writing improvements.
    
    Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
    jdapena and joyeecheung committed Jun 27, 2023
    Copy the full SHA
    b6860f4 View commit details
    Browse the repository at this point in the history
  2. More clarifications of Node.js specific parts

    When we tried to make the post less Node.js specific, we want a bit
    too far, as the parts related to --heapsnapshot-near-heap-limit are
    indeed Node.js specific. Provided more clarity on that.
    jdapena committed Jun 27, 2023
    Copy the full SHA
    77c2744 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    9eac65c View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. More accurate description of --heapsnapshot-near-heap-limit implement…

    …ation
    
    Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
    jdapena and joyeecheung committed Jun 28, 2023
    Copy the full SHA
    53d996a View commit details
    Browse the repository at this point in the history
  2. More details of source position caching fix

    The level of details in teh source position caching fix explanation
    was quite poor, not even explaining why the source line position was
    not cached. Expand it after proposal from Joyee Cheung.
    jdapena committed Jun 28, 2023
    Copy the full SHA
    a0518ff View commit details
    Browse the repository at this point in the history
  3. Reduce ambiguity of development and production JS code reference

    In previous version, we talked about "unoptimized development JS" and
    "optimized production JS", that could be misleading, as Joyee Cheung
    pointed out, because it could induce reader to think about JS runtime
    optimizations.
    
    So this change removes reference there to optimized/unoptimized JS to
    later detail how production source code is optimized using bundling
    and minification.
    jdapena committed Jun 28, 2023
    Copy the full SHA
    f02741a View commit details
    Browse the repository at this point in the history
  4. Rewrite description of V8 heap limit configuration.

    In the original description, we wrongly state that the heap limit is
    set by V8 to be 1400MB. Instead of this, it was an application
    specific limit.
    
    Also clarify that, in the test case, hitting Out-Of-Memory would hint
    there was a leak.
    
    Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
    jdapena and joyeecheung committed Jun 28, 2023
    Copy the full SHA
    bc0bcee View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Apply suggestions from Joyee code review

    Many insightful improvements to the writing of heap snapshot optimizations blog post, that can be landed altogether.
    
    Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
    jdapena and joyeecheung committed Jul 12, 2023
    Copy the full SHA
    91525cd View commit details
    Browse the repository at this point in the history
  2. Remove unneeded reference from heap snapshot optimization post

    "And old friend" reference was for the ETW fix that I presented in a different blog post that is not even linked. And it is redundant as later I explain that this issue is similar to another one fixed in ETW.
    
    Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
    jdapena and joyeecheung committed Jul 12, 2023
    Copy the full SHA
    69a958e View commit details
    Browse the repository at this point in the history
  3. Crop images to improve readability

    The images in the v8 heap snapshot optimizations post were too much
    big, with lots of empty space that was not relevant and made it harder
    to read the contents. After cropping the images, not it is more
    focused on the information that matters.
    jdapena committed Jul 12, 2023
    Copy the full SHA
    1689958 View commit details
    Browse the repository at this point in the history
  4. Apply suggestions from @syg code review

    Co-authored-by: Shu-yu Guo <syg@chromium.org>
    jdapena and syg committed Jul 12, 2023
    Copy the full SHA
    3a1cdd9 View commit details
    Browse the repository at this point in the history
  5. Apply suggestions from @syg in pull request.

    Manually apply suggestions that could not be applied directly from
    the GH UI.
    jdapena committed Jul 12, 2023
    Copy the full SHA
    91dc5a8 View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    3899164 View commit details
    Browse the repository at this point in the history
  7. Do not use specific names explaining the heap snapshot performance in…

    …vestigation
    
    Following @syg recommendation, avoid explicit engineers reference
    while explaining the procedure to investigate the performance problem.
    jdapena committed Jul 12, 2023
    Copy the full SHA
    de70d28 View commit details
    Browse the repository at this point in the history
  8. Remove sponsorship reference in heap optimizations post

    V8 team is not sponsored. Work is actually done by engineers of
    different companies. Rewrite the credits section accordingly.
    jdapena committed Jul 12, 2023
    Copy the full SHA
    3811c74 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. Copy the full SHA
    c89f34f View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. speeding-up-heap-snapshots.md: apply suggestions from Joyee code review

    Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
    jdapena and joyeecheung committed Jul 18, 2023
    Copy the full SHA
    239123a View commit details
    Browse the repository at this point in the history
  2. Update speeding-up-v8-heap-snapshot.md: replace obscure reference to …

    …previous post
    
    Originally the blog post was part of a series until it was proposed
    to be an independent post in v8.dev. Make the reference to the
    previous post independent of the fact by referring to the link of
    the previous post.
    jdapena committed Jul 18, 2023
    Copy the full SHA
    3785dbe View commit details
    Browse the repository at this point in the history
  3. speeding-up-v8-snapshots.md: following recommendations from Joyee, si…

    …mplified writing
    
    Several changes to reduce redundancies and simplify reading the
    post:
    - Remove step-by-step guide of using Windows Performance Recording,
    referring to upstream documentation now.
    - Snippets are now almost C++ code instead of pseudocode.
    - Some typos.
    - Simplified line break caching explanation, and removed reference
    to equivalent ETW fix.
    jdapena committed Jul 18, 2023
    Copy the full SHA
    c603786 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    979a434 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. speeding-up-v8-heap-snapshots.md: apply suggestions from @syg

    Co-authored-by: Shu-yu Guo <syg@chromium.org>
    jdapena and syg committed Jul 19, 2023
    Copy the full SHA
    ca5bf19 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    bdd5b96 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Copy the full SHA
    8f083a8 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    b065c43 View commit details
    Browse the repository at this point in the history