Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: copy source maps for frontend resources (#12701) (CP: 2.7) #12731

Merged
merged 1 commit into from
Jan 25, 2022
Merged

fix: copy source maps for frontend resources (#12701) (CP: 2.7) #12731

merged 1 commit into from
Jan 25, 2022

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Jan 16, 2022

Description

A manual cherry-pick of #12701 to 2.7.

Type of change

  • Bugfix

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@CLAassistant
Copy link

CLAassistant commented Jan 16, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@vursen vursen changed the base branch from master to 2.7 January 16, 2022 10:07
@vursen vursen changed the title fix: copy source maps for frontend resources (#12701) (CP: 2.8) fix: copy source maps for frontend resources (#12701) (CP: 2.7) Jan 16, 2022
@vursen vursen requested a review from platosha January 17, 2022 07:23
@caalador
Copy link
Contributor

This could be closed as 2.7 doesn't support Vite

caalador
caalador requested changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@caalador caalador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the value of this for V14 as it doesn't support Vite?

@vursen
Copy link
Contributor Author

vursen commented Jan 25, 2022 •
edited

What is the value of this for V14 as it doesn't support Vite?

This fix doesn't only target Vite. There is a general problem that the browser is currently unable to load the source map referenced in a JS resource because the source map link leads to 404. It doesn't exist because it has not been copied. Vite has simply uncovered this issue.

@vursen vursen merged commit 46023cc into 2.7 Jan 25, 2022
@vursen vursen deleted the cp/2.7/move-source-maps-to-frontend-dest branch January 25, 2022 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@platosha platosha platosha approved these changes

@caalador caalador caalador approved these changes

Assignees
No one assigned
Labels
+1.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vursen @CLAassistant @caalador @platosha @vaadin-bot