Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix ip binding problem with Vite 3 #14040

Merged
merged 1 commit into from Jun 27, 2022
Merged

fix: Fix ip binding problem with Vite 3 #14040

merged 1 commit into from Jun 27, 2022

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Jun 23, 2022

Use 127.0.0.1 both for the Vite server and when connecting to it to ensure it works

Fixes #14021

@Artur-
fix: Fix ip binding problem with Vite 3
d382762 
Use 127.0.0.1 both for the Vite server and when connecting to it to ensure it works

Fixes #14021
@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Unit Test Results

   980 files  +   519     980 suites  +519   52m 50s ⏱️ + 12m 25s
6 316 tests +5 471  6 268 ✔️ +5 463  48 💤 +8  0 ❌ ±0 
6 578 runs  +5 515  6 524 ✔️ +5 507  54 💤 +8  0 ❌ ±0 

Results for commit d382762. ± Comparison against base commit 171ae45.

@Artur- Artur- requested a review from vursen June 23, 2022 12:54
@taefi taefi merged commit fc16509 into master Jun 27, 2022
@taefi taefi deleted the support-vite3 branch June 27, 2022 11:13
vaadin-bot pushed a commit that referenced this pull request Jun 27, 2022
@Artur- @vaadin-bot
fix: Fix ip binding problem with Vite 3 (#14040)
9092c49 
Use 127.0.0.1 both for the Vite server and when connecting to it to ensure it works

Fixes #14021
vaadin-bot pushed a commit that referenced this pull request Jun 27, 2022
@Artur- @vaadin-bot
fix: Fix ip binding problem with Vite 3 (#14040)
cd5935d 
Use 127.0.0.1 both for the Vite server and when connecting to it to ensure it works

Fixes #14021
@vaadin-bot
Copy link
Collaborator

Hi @Artur- and @taefi, when i performed cherry-pick to this commit to 2.8, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick fc16509
error: could not apply fc16509... fix: Fix ip binding problem with Vite 3 (#14040)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

vaadin-bot pushed a commit that referenced this pull request Jun 27, 2022
@Artur- @vaadin-bot
fix: Fix ip binding problem with Vite 3 (#14040)
40977b6 
Use 127.0.0.1 both for the Vite server and when connecting to it to ensure it works

Fixes #14021
@vaadin-bot
Copy link
Collaborator

Hi @Artur- and @taefi, when i performed cherry-pick to this commit to 2.7, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick fc16509
error: could not apply fc16509... fix: Fix ip binding problem with Vite 3 (#14040)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

mcollovati pushed a commit that referenced this pull request Jun 27, 2022
@vaadin-bot @Artur-
fix: Fix ip binding problem with Vite 3 (#14040) (#14069)
46755ee 
Use 127.0.0.1 both for the Vite server and when connecting to it to ensure it works

Fixes #14021

Co-authored-by: Artur <artur@vaadin.com>
mcollovati pushed a commit that referenced this pull request Jun 27, 2022
@vaadin-bot @Artur-
fix: Fix ip binding problem with Vite 3 (#14040) (#14071)
61abf71 
Use 127.0.0.1 both for the Vite server and when connecting to it to ensure it works

Fixes #14021

Co-authored-by: Artur <artur@vaadin.com>
Artur- pushed a commit that referenced this pull request Jun 27, 2022
@vaadin-bot
fix: Fix ip binding problem with Vite 3 (#14040) (#14070)
4867f73 
Use 127.0.0.1 both for the Vite server and when connecting to it to ensure it works

Fixes #14021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taefi taefi taefi approved these changes

@vursen vursen Awaiting requested review from vursen

Assignees
No one assigned
Labels
cherry-picked-9.0 cherry-picked-23.0 cherry-picked-23.1 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using Vite 3.0.0-beta.0 does not work
3 participants
@Artur- @vaadin-bot @taefi