-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Hilla stats to detect Lit vs. React usage based on deployment configuration #2129
Comments
That won't be reliable in the case of application that use both Lit and React side-by-side since the current idea of how to make sure you have both |
That's correct, as just |
I suspect I wonder if the logic should be such that if |
Even though, this should work now, this logic doesn't seem to be very fluent. I wonder if we should allow having Probably this discussion is a bit off-topic here and we should just be talking about what we need from Flow APIs, e.g. either we need
|
There's a bunch of detection methods added in Flow recently that could be helpful. See https://github.com/vaadin/flow/blob/main/flow-server/src/main/java/com/vaadin/flow/server/frontend/FrontendUtils.java |
There is a unit-test |
* fix: adjust Hilla statistics collection Fixes #2129 * cleanup * adjust java stats * gather hilla usage stats * gather createMenuItems usage stats * gather createMenuItems usage stats * add stats for createMenuItems usage --------- Co-authored-by: Anton Platonov <platosha@gmail.com>
* fix: adjust Hilla statistics collection Fixes #2129 * cleanup * adjust java stats * gather hilla usage stats * gather createMenuItems usage stats * gather createMenuItems usage stats * add stats for createMenuItems usage --------- Co-authored-by: Anton Platonov <platosha@gmail.com>
fix: adjust Hilla statistics collection (#2353) * fix: adjust Hilla statistics collection Fixes #2129 * cleanup * adjust java stats * gather hilla usage stats * gather createMenuItems usage stats * gather createMenuItems usage stats * add stats for createMenuItems usage --------- Co-authored-by: Soroosh Taefi <taefi.soroosh@gmail.com> Co-authored-by: Anton Platonov <platosha@gmail.com>
This ticket/PR has been released with Hilla 24.4.0.beta4 and is also targeting the upcoming stable 24.4.0 version. |
This ticket/PR has been released with Hilla 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version. |
Describe the bug
Hilla stats where being gathered based on the usage of
hilla-react
artifact, and now that thehilla-react
is not there anymore, we can decide whether is it a Lit or React app based onDeplymentConfiguration
's method calledisReactEnabled
.Expected-behavior
Reproduction
Previous unit test for HillaStats is failing.
System Info
N/A
The text was updated successfully, but these errors were encountered: