-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adjust Hilla statistics collection #2353
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2353 +/- ##
==========================================
- Coverage 95.11% 95.07% -0.05%
==========================================
Files 66 66
Lines 4507 4510 +3
Branches 645 646 +1
==========================================
+ Hits 4287 4288 +1
- Misses 179 181 +2
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The description mentions three out of the four potential states of the two booleans. Is there a possibility that the fourth option could ever happen, i.e. |
…i/fix-hilla-stats
Quality Gate passedIssues Measures |
* fix: adjust Hilla statistics collection Fixes #2129 * cleanup * adjust java stats * gather hilla usage stats * gather createMenuItems usage stats * gather createMenuItems usage stats * add stats for createMenuItems usage --------- Co-authored-by: Anton Platonov <platosha@gmail.com>
fix: adjust Hilla statistics collection (#2353) * fix: adjust Hilla statistics collection Fixes #2129 * cleanup * adjust java stats * gather hilla usage stats * gather createMenuItems usage stats * gather createMenuItems usage stats * add stats for createMenuItems usage --------- Co-authored-by: Soroosh Taefi <taefi.soroosh@gmail.com> Co-authored-by: Anton Platonov <platosha@gmail.com>
This ticket/PR has been released with Hilla 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version. |
Description
This adjusts the Hilla statistics gathering based on what's explained in vaadin/platform#6430
Fixes #2129
Type of change
Checklist