Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust Hilla statistics collection #2353

Merged
merged 13 commits into from
May 20, 2024
Merged

fix: adjust Hilla statistics collection #2353

merged 13 commits into from
May 20, 2024

Conversation

taefi
Copy link
Contributor

@taefi taefi commented Apr 24, 2024

Description

This adjusts the Hilla statistics gathering based on what's explained in vaadin/platform#6430

Fixes #2129

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.07%. Comparing base (016abe8) to head (f0e85bf).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2353      +/-   ##
==========================================
- Coverage   95.11%   95.07%   -0.05%     
==========================================
  Files          66       66              
  Lines        4507     4510       +3     
  Branches      645      646       +1     
==========================================
+ Hits         4287     4288       +1     
- Misses        179      181       +2     
  Partials       41       41              
Flag Coverage Δ
unittests 95.07% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Legioth
Copy link
Member

Legioth commented Apr 25, 2024

The description mentions three out of the four potential states of the two booleans. Is there a possibility that the fourth option could ever happen, i.e. FrontendUtils.isReactRouterRequired() == false && deploymentConfiguration.isReactEnabled() == true?

@taefi taefi marked this pull request as ready for review May 16, 2024 10:51
Copy link

sonarcloud bot commented May 20, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@platosha platosha merged commit 1c7ccd2 into main May 20, 2024
14 of 15 checks passed
@platosha platosha deleted the taefi/fix-hilla-stats branch May 20, 2024 11:00
vaadin-bot pushed a commit that referenced this pull request May 20, 2024
* fix: adjust Hilla statistics collection

Fixes #2129

* cleanup

* adjust java stats

* gather hilla usage stats

* gather createMenuItems usage stats

* gather createMenuItems usage stats

* add stats for createMenuItems usage

---------

Co-authored-by: Anton Platonov <platosha@gmail.com>
platosha added a commit that referenced this pull request May 20, 2024
fix: adjust Hilla statistics collection (#2353)

* fix: adjust Hilla statistics collection

Fixes #2129

* cleanup

* adjust java stats

* gather hilla usage stats

* gather createMenuItems usage stats

* gather createMenuItems usage stats

* add stats for createMenuItems usage

---------

Co-authored-by: Soroosh Taefi <taefi.soroosh@gmail.com>
Co-authored-by: Anton Platonov <platosha@gmail.com>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Hilla 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Hilla stats to detect Lit vs. React usage based on deployment configuration
5 participants