fix: support Maven system scope for dependencies #2328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2328 +/- ##
=======================================
Coverage 95.11% 95.11%
=======================================
Files 66 66
Lines 4507 4507
Branches 645 645
=======================================
Hits 4287 4287
Misses 179 179
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SonarCloud is complaining about the system scope dependency I added in the test, but that's of course necessary. |
platosha
approved these changes
May 20, 2024
|
|
This ticket/PR has been released with Hilla 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dependencies with scope
systemare added to a Hilla project, we need support from Maven, Spring Boot, and Hilla itself for them to work.Maven support system dependencies, although deprecated. No action is needed for them to work.
Spring Boot requires enabling support explicitly. This is done by adding
<includeSystemScope>true</includeSystemScope>to thespring-boot-maven-pluginconfiguration, for all profiles.This PR adds support in Hilla: system dependencies can now include endpoints and entities. For the endpoints to be found, the package must be listed in the Vaadin plugin configuration as usual.
This PR needs vaadin/flow#19175 to work. ✅
Fixes #2230