refactor: disallow parametrized items in auto menu

[Lodin]

Fixes #2378.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.13%. Comparing base (6aba671) to head (64f8a6e).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2392      +/-   ##
==========================================
+ Coverage   95.12%   95.13%   +0.01%     
==========================================
  Files          66       66              
  Lines        4512     4501      -11     
  Branches      649      646       -3     
==========================================
- Hits         4292     4282      -10     
+ Misses        179      178       -1     
  Partials       41       41              

Flag	Coverage Δ
unittests	95.13% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[platosha]

Let's keep the test fixtures for optional and wildcard parameters, as they (apart from known bugs and quirks) are supported use cases.

[taefi]

From the code changes POV it LGTM!
From the tests POV, I agree with @platosha's comment regarding the support of views with optional params. So, I'm not going to restate those requested changes.

[platosha]

Upon a closer look, there is still an issue that the link target path contains optional segments, such as /:___commentId? in /comments/:___commentId?, for example. Somewhere we need to omit them...

[platosha]

Upon a closer look, there is still an issue that the link target path contains optional segments, such as /:___commentId? in /comments/:___commentId?, for example. Somewhere we need to omit them...

addressed in ba2a093

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[platosha]

From the code changes POV it LGTM! From the tests POV, I agree with @platosha's comment regarding the support of views with optional params. So, I'm not going to restate those requested changes.

I went with the tactic to omit the segments in Java, as it is more convenient there having the parameter info. Now that createMenuItems has nothing to do with route parameters, it just uses the path key as is — omitting tests for the use cases is fine.

[vaadin-bot]

Hi @Lodin and @Lodin, when i performed cherry-pick to this commit to 24.4, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick d748cb4
error: could not apply d748cb4... refactor: disallow parametrized items in auto menu (#2392)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".