feat!(frontend): reload the page on login / logout success #2432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2432 +/- ##
==========================================
- Coverage 95.13% 95.02% -0.11%
==========================================
Files 66 66
Lines 4524 4546 +22
Branches 648 658 +10
==========================================
+ Hits 4304 4320 +16
- Misses 179 182 +3
- Partials 41 44 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
platosha
changed the title
platosha
force-pushed
the
fix/auth/logout
branch
5 times, most recently
from
6b4acde
to
2cd96d0
Compare
platosha
changed the title
platosha
changed the title
platosha
changed the title
mcollovati
previously approved these changes
May 24, 2024
Lodin
commented
May 27, 2024
Lodin
commented
May 27, 2024
|
platosha
approved these changes
May 27, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
May 27, 2024
* refactor: prefer full page reload instead of AJAX request on logout * Revert "refactor: prefer full page reload instead of AJAX request on logout" This reverts commit 47880c1. * fix: reload the page on login / logout success * fix: restore Spring CSRF handling * fix: normalize redirect as path * test: prevent flackyness of parallel security tests * fix(frontend): support context path in redirects * chore: cleanup * test(security): verify server-side logout redirect location * test(security): make tests more reliable * fix: normalize default redirect URL * test(security): expect page reload from API * chore: Java formatting * fix: more accurate normalize url * test(security): extra wait for page load * test(security): extra wait for page load * test(security): extra wait for page load * test(security): more explicit load waiting * chore: cleanup * test(security): fix load waiting * chore: Java formatting * test: add implicit wait * test: rollback asserting path, use builtin wait for main-view * test: assertin path using script * fix: reload with url mapping * test: wait for invalid session reloads * chore: remove test logger * test: extra wait on open * Revert "test: prevent flackyness of parallel security tests" This reverts commit 77721ae. * fix(frontend): prevent following requests when pageReloadNavigation is in use * Revert "test: add implicit wait" This reverts commit ed7d66d. * feat!(frontend): onSuccess login / logout callbacks for custom after-flows * test: use onSuccess callbacks * test: wait for load when asserting current URL * test: apply url mapping to logout path * chore(frontend): remove unnecessary .toString() * feat(frontend): support URL in login / logout options --------- Co-authored-by: Anton Platonov <platosha@gmail.com> Co-authored-by: Soroosh Taefi <taefi.soroosh@gmail.com>
platosha
added a commit
that referenced
this pull request
May 27, 2024
…P: 24.4) (#2481) feat!(frontend): reload the page on login / logout success (#2432) * refactor: prefer full page reload instead of AJAX request on logout * Revert "refactor: prefer full page reload instead of AJAX request on logout" This reverts commit 47880c1. * fix: reload the page on login / logout success * fix: restore Spring CSRF handling * fix: normalize redirect as path * test: prevent flackyness of parallel security tests * fix(frontend): support context path in redirects * chore: cleanup * test(security): verify server-side logout redirect location * test(security): make tests more reliable * fix: normalize default redirect URL * test(security): expect page reload from API * chore: Java formatting * fix: more accurate normalize url * test(security): extra wait for page load * test(security): extra wait for page load * test(security): extra wait for page load * test(security): more explicit load waiting * chore: cleanup * test(security): fix load waiting * chore: Java formatting * test: add implicit wait * test: rollback asserting path, use builtin wait for main-view * test: assertin path using script * fix: reload with url mapping * test: wait for invalid session reloads * chore: remove test logger * test: extra wait on open * Revert "test: prevent flackyness of parallel security tests" This reverts commit 77721ae. * fix(frontend): prevent following requests when pageReloadNavigation is in use * Revert "test: add implicit wait" This reverts commit ed7d66d. * feat!(frontend): onSuccess login / logout callbacks for custom after-flows * test: use onSuccess callbacks * test: wait for load when asserting current URL * test: apply url mapping to logout path * chore(frontend): remove unnecessary .toString() * feat(frontend): support URL in login / logout options --------- Co-authored-by: Vlad Rindevich <vladrin@vaadin.com> Co-authored-by: Anton Platonov <platosha@gmail.com> Co-authored-by: Soroosh Taefi <taefi.soroosh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2235
In addition, introduces
onSuccessandnavigatecallbacks for custom authentication workflows, such as retrieving user info and offline storage.