fix!: Disable HotSwap endpoint changes by default #2434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of 24.4 that Hilla is part of the Vaadin Platform the Hilla automatic registration for reloading the Endpoint changes (when HotSwapAgent is enabled) makes unnecessary noise in general Vaadin applications that not necessarily using any Endpoints at all, so it is disabled by default and could be enabled on demand by adding the following to the application.properties: hilla.endpoint.hot-reload.enabled=true This approach is going to be removed and replaced with a better support for reloading the changes in general for both Hilla and Flow.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 24.4 #2434 +/- ##
=======================================
Coverage ? 95.11%
=======================================
Files ? 66
Lines ? 4507
Branches ? 645
=======================================
Hits ? 4287
Misses ? 179
Partials ? 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
platosha
approved these changes
May 20, 2024
|
taefi
deleted the
taefi/disable-hotswap-endpoint-changes-polling-by-default
branch
|
This ticket/PR has been released with Hilla 24.4.0.beta4 and is also targeting the upcoming stable 24.4.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As of 24.4 that Hilla is part of the Vaadin Platform, the Hilla automatic registration for reloading the Endpoint changes (when HotSwapAgent is enabled) makes unnecessary noise in general Vaadin applications that not may not have any Endpoints at all, so it is disabled by default and could be enabled on demand by adding the following to the
application.properties:This approach is going to be removed and replaced with a better support for reloading the changes in general for both Hilla and Flow.