chore: set type
to module
in package.json
#3280
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
type
property of apackage.json
is commonly used by frontend tooling for detecting whether the package's entry point is a CJS or ES module. If no property is specified, the entry point may be treated as a CJS module according to Node.js docs which is not true in the case of Vaadin web components. To illustrate the situation, here is a warning that Vite shows when you import a Vaadin web component:This PR explicitly sets the
type
property tomodule
to avoid possible misinterpretation.Related to vaadin/flow#12574
Type of change