Fix typedoc prepare script to use npm #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason: typedoc has package.lock, and yarn install would not install locked dependencies but the newest one, hence breaking on newer packages than the ones that actually work being pulled
|
Note: hopefully, the original reason why we forked typedoc will be addressed in the upcoming 0.21 version: TypeStrong/typedoc#112 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason: typedoc has package.lock, and yarn install (what was being previously used) would not install locked
dependencies but the newest ones, hence breaking on newer packages than the ones that actually work being pulled
Further context: we are using a custom fork of typedoc which doesn't sort the properties, which gets downloaded and built within our repo: ppershing/typedoc@f32157c
I noticed the installation of the dependencies within the typedoc build step results in vulnerabilities being reported but these dependencies don't interfere with the dependencies of our package and is ran as a separate script to build the docs
Additionaly, yarn audit on ledgerjs repo itself was failing with glob-parent dependency so I fixed that as well