Add useInput hook to handle user input
#227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadimdemedes
force-pushed
the
useinput
branch
from
82341aa
to
6214d00
Compare
|
@sindresorhus Great feedback, fixed everything! Regarding #227 (comment), I was unable to reproduce |
vadimdemedes
force-pushed
the
useinput
branch
from
62ad031
to
5ae2cc1
Compare
|
@vadimdemedes Look at how Node.js does the detection: https://github.com/nodejs/node/blob/ab841d5fbab1a9d2f8323d1ae3f71f37c6f636a1/lib/internal/readline/utils.js#L168-L172 |
|
I meant I wasn't able to trigger the meta key, not to implement the detection of it. I tried pressing Cmd + letter, but terminal seems to ignore that combination. |
vadimdemedes
force-pushed
the
useinput
branch
from
5ae2cc1
to
460125e
Compare
|
@sindresorhus Meta key is in. |
Co-Authored-By: Sindre Sorhus <sindresorhus@gmail.com>
Co-Authored-By: Sindre Sorhus <sindresorhus@gmail.com>
Co-Authored-By: Sindre Sorhus <sindresorhus@gmail.com>
Co-Authored-By: Sindre Sorhus <sindresorhus@gmail.com>
vadimdemedes
force-pushed
the
useinput
branch
from
ba3cf45
to
44e9fa5
Compare
Co-Authored-By: Sindre Sorhus <sindresorhus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #147. Thanks to @jedahan for implementing the initial
useKeypresshook. This PR changes it to listen todataevent instead ofkeypressand renames the hook touseInput.