feat: add <Line> component to render horizontal and vertical lines
#556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlCalzone
commented
Mar 13, 2023
| if ('borderStyle' in style) { | ||
| const borderWidth = typeof style.borderStyle === 'string' ? 1 : 0; | ||
| const borderWidth = | ||
| domNode.nodeName === 'ink-line' |
There was a problem hiding this comment.
I needed access to nodeName here, so I figured I'd update all the applyXYZ method to take the DOM node instead.
|
I'd prefer to ship #475 instead, which will let you render |
|
Fine by me. Out of curiosity, what's blocking that PR? |
|
Nothing technical, only my availability. |
|
Closing this, since border sides can now be disabled individually → https://github.com/vadimdemedes/ink#bordertop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I previously tried to achieve this by measuring a
Boxand rendering text instead, but as mentioned in #472 (comment), themeasureElementAPI often does not work in more complex layouts (returnsNaN).Since
inkdoes draw boxes correctly, I figured I'd try this by implementing aLinecomponent, soinkcan handle drawing the lines.