New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: only focus active elements #631
base: master
Are you sure you want to change the base?
Conversation
We now target Node.js 18, so it should be fine to use |
Cool, I'll fix it up soon |
6c2a1f7
to
ffac7a5
Compare
Done! |
@acdibble Thanks for this PR! Could you add a test for this behavior? |
@vadimdemedes , I added three tests. I also had to update the tsconfig to include the |
When wrapping around at the beginning or end of the list of components, we should search respectively for the last or first active component.
I didn't use
Array.prototype.findLast
because thetsconfig
doesn't support it and it was simple enough to write a loop.