remove WireLength fix for InPayload calc

grpc fixes it in grpc/grpc-go#3886
vadimi · Oct 9, 2020 · 75de31f · 75de31f
1 parent c17d8aa
commit 75de31f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/internal/rpc/stats.go b/internal/rpc/stats.go
@@ -31,10 +31,7 @@ func (s *Stats) record(rpcStats stats.RPCStats) {
 	case *stats.InHeader:
 		atomic.AddInt64(&s.respSize, int64(v.WireLength))
 	case *stats.InPayload:
-		// TODO(spencer): remove the +5 offset on wire length here, which
-		// is a temporary stand-in for the missing GRPC framing offset.
-		// See: https://github.com/grpc/grpc-go/issues/1647.
-		atomic.AddInt64(&s.respSize, int64(v.WireLength+5))
+		atomic.AddInt64(&s.respSize, int64(v.WireLength))
 	case *stats.InTrailer:
 		atomic.AddInt64(&s.respSize, int64(v.WireLength))
 	case *stats.OutHeader:

diff --git a/internal/rpc/stats_test.go b/internal/rpc/stats_test.go
@@ -52,7 +52,7 @@ func TestRPCStatsRecording(t *testing.T) {
 		t.Errorf("invalid req size: %d, expected: %d", s.ReqSize(), expectedReqSize)
 	}
 
-	expectedRespSize := int64(11)
+	expectedRespSize := int64(6)
 	if s.RespSize() != expectedRespSize {
 		t.Errorf("invalid resp size: %d, expected: %d", s.RespSize(), expectedRespSize)
 	}