-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/4.0 #88
Feature/4.0 #88
Conversation
…it to boilerplate components
…jection during development
# Conflicts: # app/components/c-date-picker-input.vue # app/components/c-table-pagination.vue # app/components/c-table.vue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Very minor issue: naming of the headings is misleading because it's 700 spacing ;)
- There is no value handling on e-input where you can toggle the disabled state. I think this would be nice to test if it works correctly.
- The disabled color is very light, so I think it's hard to see on many screens. Also it's different sometimes (e.g. Radio button)
- close button in notifications seems off place:
- Currently panel can't be opened or closed in styleguide. Is this on purpose?
- No swiper gallery in styleguide
- There are console warnings when opening the modal
- Notifications are not displayed in modals
- c-modal-header-01 is not displayed in styleguide
- No margin for notifications, but I think that was already before the case
I'll leave this for now, since it needs to be changed for each project anyway.
As I understand it, the state/content is handled by the parent component. It emits a click event. So I will leave this for now.
Could not be reproduced. Maybe fixed with other changes.
Could not be reproduced. Maybe fixed with other changes.
I'll leave this for now, since it needs to be changed for each project anyway. |
@patric-eberle nice work! |
Pull request
This PR prepares the boilerplate for future projects:
Ticket
No ticket
Browser testing
Checklist
Review/Test checklist