Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Docker image arm support #27

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

abbudao
Copy link
Contributor

@abbudao abbudao commented Oct 10, 2023

Draft for arm support for bloom.

Proposed changes

  • Support docker images for arm64 by leveraging buildx multi-platform images.
  • Changed optimize for speed instead of size. This will lead to a binary 800kb larger but with a possibly optimized binary.
  • Use codegen-units=1 for slower compilations but better results
  • Stop using musl to use glibc. I had problems with performance issues and weird DNS behaviors using musl in the past. As you probably know, musl is intended to be a more straightforward implementation and is less optimized than glibc. For this change work, we need to switch from scratch to distroless, increasing the final image size from 5 MB to 28MB, which I believe is still tiny.

@abbudao abbudao marked this pull request as draft October 10, 2023 13:52
@abbudao abbudao changed the title Arm support feat: Docker image arm support Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant