Corrected possible attributes for input elements #1455
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR slightly reworks web-forms.rnc & web-forms2.rnc, correcting list of possible form attributes for each input type. It made usage of INPUT_ATTRIBUTES in Assertions.java obsolete and was removed. Now any invalid attribute in input element shows error like that:
I have also cleaned up both rnc files a little bit, moving all attributes to web-forms.rnc & connecting input types which were present in both files.
Fixes #1149
I think it would be better to make web-forms-input.rnc and move all rules regarding input types in there. In web-forms2.rnc there would be just few rules, so we could be move them to web-forms.rnc and delete the file.
We could also change naming of types regarding form attributes, because currently they are under:
What do you think?