Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected possible attributes for input elements #1455

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NiedziolkaMichal
Copy link
Collaborator

@NiedziolkaMichal NiedziolkaMichal commented Oct 26, 2022

This PR slightly reworks web-forms.rnc & web-forms2.rnc, correcting list of possible form attributes for each input type. It made usage of INPUT_ATTRIBUTES in Assertions.java obsolete and was removed. Now any invalid attribute in input element shows error like that:
image

I have also cleaned up both rnc files a little bit, moving all attributes to web-forms.rnc & connecting input types which were present in both files.

Fixes #1149

I think it would be better to make web-forms-input.rnc and move all rules regarding input types in there. In web-forms2.rnc there would be just few rules, so we could be move them to web-forms.rnc and delete the file.
We could also change naming of types regarding form attributes, because currently they are under:

  1. shared-form.attrs
  2. common-form.attrs
  3. input.attrs

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect list attribute is not detected
1 participant